Support for links for policies with variable as 2nd argument#334
Open
N1ebieski wants to merge 14 commits intolaravel:mainfrom
Open
Support for links for policies with variable as 2nd argument#334N1ebieski wants to merge 14 commits intolaravel:mainfrom
N1ebieski wants to merge 14 commits intolaravel:mainfrom
Conversation
…nto Support-for-links-for-policies-with-variable-as-2nd-argument-#23
…o the model php template
…nto Support-for-links-for-policies-with-variable-as-2nd-argument-#23
Contributor
Author
|
Small improvement from laravel/vs-code-php-parser-cli#14 (comment) |
…or-policies-with-variable-as-2nd-argument-#23
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #264, #454
This PR adds support for links for policies with variable as 2nd argument.
Before:
After:
Most of the logic is in the laravel/vs-code-php-parser-cli#14
First, the extension tries to use
classNamewhich returns php-parser. If theclassNameisnull(for example, php-parser cannot find namespace in blade file), then theanalyzeParamfunction tries to find a model's policy by variable's name usingName,name,camelNameandsnake_name.There is the experimental support for variable's docblocks > laravel/vs-code-php-parser-cli#14 (comment)